Dashboard: Telemetry Settings Opt-In Checkbox #4330
Conversation
carloskelly13
added
Type: Enhancement
carloskelly13
requested review from
spacedmonkey and
swissspidy
as code owners
|
Size Change: +1.56 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
assets/src/dashboard/app/views/editorSettings/telemetry/index.js
Outdated
Show resolved
Hide resolved
|
Updated screenshot since we need to split the sentence from the link.
|
There was a problem hiding this comment.
This works great - tested with keyboard + mouse on chrome, firefox, and safari.
There's one other part of the settings page that is going to need to be updated if I understand the discussion on #3165 correctly:
In this case, the settings page would be available to all users, but non-Admins should only be able to manage this setting (for now). The rest of the settings should only be visible to Admin users. I will update on the brief.
Right now, the settings route is only built if the enableSettingsFlag is true and canManageSettings from config is also true. Now that the specs on this page have changed we need to enable the route in dashboard/app/index and in the sidenav component if the enableSettingsFlag is true and then disable the analytics and file upload/ ability to edit logos if canManageSettings is false.
i feel like this would be a good separate PR.
Codecov Report
@@ Coverage Diff @@
## main #4330 +/- ##
===========================================
+ Coverage 70.02% 83.23% +13.21%
===========================================
Files 835 837 +2
Lines 14728 14809 +81
===========================================
+ Hits 10313 12327 +2014
+ Misses 4415 2482 -1933
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Summary
Add a checkbox for telemetry settings for opt-in for tracking
Relevant Technical Choices
Follows existing pattern of adding a setting to the settings page of a separate component.
To-do
None
User-facing changes
Testing Instructions
The entire label should be clickable.
The Google Privacy link should open a new page but not change the state.
#3165